From: Wei Yongjun Date: Tue, 10 Sep 2013 22:56:35 +0000 (+0800) Subject: drm/exynos: fix return value check in lowlevel_buffer_allocate() X-Git-Tag: v3.12-rc2~3^2~1^2 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=662bb6992a505ad41db3c8b52b1e70934507c2e2;p=~emulex%2Finfiniband.git drm/exynos: fix return value check in lowlevel_buffer_allocate() In case of error, the function drm_prime_pages_to_sg() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun Signed-off-by: Inki Dae --- diff --git a/drivers/gpu/drm/exynos/exynos_drm_buf.c b/drivers/gpu/drm/exynos/exynos_drm_buf.c index d20a7afab57..9c8088462c2 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_buf.c +++ b/drivers/gpu/drm/exynos/exynos_drm_buf.c @@ -91,9 +91,9 @@ static int lowlevel_buffer_allocate(struct drm_device *dev, } buf->sgt = drm_prime_pages_to_sg(buf->pages, nr_pages); - if (!buf->sgt) { + if (IS_ERR(buf->sgt)) { DRM_ERROR("failed to get sg table.\n"); - ret = -ENOMEM; + ret = PTR_ERR(buf->sgt); goto err_free_attrs; }