From: Michael Krufky <mkrufky@linuxtv.org>
Date: Tue, 22 Apr 2008 17:41:50 +0000 (-0300)
Subject: V4L/DVB (7126): tuner: move tuner type ID check to simple_tuner_attach
X-Git-Tag: v2.6.26-rc1~1084^2~443
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=65e8d29f7a37faaf9c73c633447bebd4b31b2c89;p=~shefty%2Frdma-dev.git

V4L/DVB (7126): tuner: move tuner type ID check to simple_tuner_attach

Move tuner type ID check from tuner-core::set_type to simple_tuner_attach.

Since tuner-core forwards all attach requests to tuner-simple as the
default case, unless a specific attach function is specified in
set_type, this change is an appropriate cleanup.

Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
---

diff --git a/drivers/media/video/tuner-core.c b/drivers/media/video/tuner-core.c
index 770dbcbecb6..4d791766ce1 100644
--- a/drivers/media/video/tuner-core.c
+++ b/drivers/media/video/tuner-core.c
@@ -352,11 +352,6 @@ static void set_type(struct i2c_client *c, unsigned int type,
 		return;
 	}
 
-	if (type >= tuner_count) {
-		tuner_warn ("tuner 0x%02x: Tuner count greater than %d\n",c->addr,tuner_count);
-		return;
-	}
-
 	t->type = type;
 	t->config = new_config;
 	if (tuner_callback != NULL) {
diff --git a/drivers/media/video/tuner-simple.c b/drivers/media/video/tuner-simple.c
index 85556d44c8a..d3362703e25 100644
--- a/drivers/media/video/tuner-simple.c
+++ b/drivers/media/video/tuner-simple.c
@@ -688,6 +688,12 @@ struct dvb_frontend *simple_tuner_attach(struct dvb_frontend *fe,
 {
 	struct tuner_simple_priv *priv = NULL;
 
+	if (type >= tuner_count) {
+		printk(KERN_WARNING "%s: invalid tuner type: %d (max: %d)\n",
+		       __FUNCTION__, type, tuner_count-1);
+		return NULL;
+	}
+
 	priv = kzalloc(sizeof(struct tuner_simple_priv), GFP_KERNEL);
 	if (priv == NULL)
 		return NULL;