From: Christoph Hellwig Date: Sun, 6 Sep 2009 01:42:42 +0000 (-0400) Subject: ext4: fix cache flush in ext4_sync_file X-Git-Tag: v2.6.32-rc1~633^2~27 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=5f3481e9a80c240f169b36ea886e2325b9aeb745;p=~shefty%2Frdma-dev.git ext4: fix cache flush in ext4_sync_file We need to flush the write cache unconditionally in ->fsync, otherwise writes into already allocated blocks can get lost. Writes into fully allocated files are very common when using disk images for virtualization, and without this fix can easily lose data after an fdatasync, which is the typical implementation for a cache flush on the virtual drive. Signed-off-by: Christoph Hellwig Acked-by: Eric Sandeen Signed-off-by: "Theodore Ts'o" --- diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c index 83cf6415f59..ab418c0f502 100644 --- a/fs/ext4/fsync.c +++ b/fs/ext4/fsync.c @@ -92,9 +92,9 @@ int ext4_sync_file(struct file *file, struct dentry *dentry, int datasync) .nr_to_write = 0, /* sys_fsync did this */ }; ret = sync_inode(inode, &wbc); - if (journal && (journal->j_flags & JBD2_BARRIER)) - blkdev_issue_flush(inode->i_sb->s_bdev, NULL); } out: + if (journal && (journal->j_flags & JBD2_BARRIER)) + blkdev_issue_flush(inode->i_sb->s_bdev, NULL); return ret; }