From: Jan Kara Date: Thu, 30 Oct 2014 14:53:16 +0000 (-0400) Subject: ext4: fix oops when loading block bitmap failed X-Git-Tag: v3.18-rc3~15^2~8 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=599a9b77ab289d85c2d5c8607624efbe1f552b0f;p=~emulex%2Finfiniband.git ext4: fix oops when loading block bitmap failed When we fail to load block bitmap in __ext4_new_inode() we will dereference NULL pointer in ext4_journal_get_write_access(). So check for error from ext4_read_block_bitmap(). Coverity-id: 989065 Cc: stable@vger.kernel.org Signed-off-by: Jan Kara Signed-off-by: Theodore Ts'o --- diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c index 8012a5daf40..ac644c31ca6 100644 --- a/fs/ext4/ialloc.c +++ b/fs/ext4/ialloc.c @@ -887,6 +887,10 @@ got: struct buffer_head *block_bitmap_bh; block_bitmap_bh = ext4_read_block_bitmap(sb, group); + if (!block_bitmap_bh) { + err = -EIO; + goto out; + } BUFFER_TRACE(block_bitmap_bh, "get block bitmap access"); err = ext4_journal_get_write_access(handle, block_bitmap_bh); if (err) {