From: Lukas Czerner Date: Thu, 28 Oct 2010 01:30:04 +0000 (-0400) Subject: ext4: don't hold spinlock while calling ext4_issue_discard() X-Git-Tag: v2.6.37-rc1~76^2^2~42 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=53fdcf992d616484d388a8ab9dad07dc8b8f1178;p=~shefty%2Frdma-dev.git ext4: don't hold spinlock while calling ext4_issue_discard() We can't hold the block group spinlock because we ext4_issue_discard() calls wait and hence can get rescheduled. Google-Bug-Id: 3017678 Signed-off-by: Lukas Czerner Signed-off-by: "Theodore Ts'o" --- diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 53472e27b32..ccdfec6acb7 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -4696,12 +4696,12 @@ do_more: * with group lock held. generate_buddy look at * them with group lock_held */ + if (test_opt(sb, DISCARD)) + ext4_issue_discard(sb, block_group, bit, count); ext4_lock_group(sb, block_group); mb_clear_bits(bitmap_bh->b_data, bit, count); mb_free_blocks(inode, &e4b, bit, count); ext4_mb_return_to_preallocation(inode, &e4b, block, count); - if (test_opt(sb, DISCARD)) - ext4_issue_discard(sb, block_group, bit, count); } ret = ext4_free_blks_count(sb, gdp) + count;