From: Dave Airlie Date: Wed, 16 Dec 2009 03:10:43 +0000 (+1000) Subject: drm/radeon/gem: don't leak a gem object if reserve fails on get tiling (v2) X-Git-Tag: v2.6.33-rc1~62^2~7 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=51f07b7ebce15c1848743a2ba43a0005375d8243;p=~shefty%2Frdma-dev.git drm/radeon/gem: don't leak a gem object if reserve fails on get tiling (v2) Not sure it ever happens in practice, spotted during code review. spare brace snuck in Signed-off-by: Dave Airlie --- diff --git a/drivers/gpu/drm/radeon/radeon_gem.c b/drivers/gpu/drm/radeon/radeon_gem.c index ee827cc22af..60df2d7e7e4 100644 --- a/drivers/gpu/drm/radeon/radeon_gem.c +++ b/drivers/gpu/drm/radeon/radeon_gem.c @@ -351,9 +351,10 @@ int radeon_gem_get_tiling_ioctl(struct drm_device *dev, void *data, rbo = gobj->driver_private; r = radeon_bo_reserve(rbo, false); if (unlikely(r != 0)) - return r; + goto out; radeon_bo_get_tiling_flags(rbo, &args->tiling_flags, &args->pitch); radeon_bo_unreserve(rbo); +out: mutex_lock(&dev->struct_mutex); drm_gem_object_unreference(gobj); mutex_unlock(&dev->struct_mutex);