From: Roel Kluin <roel.kluin@gmail.com>
Date: Tue, 15 Dec 2009 21:55:44 +0000 (+0100)
Subject: drbd: Fix test of unsigned in _drbd_fault_random()
X-Git-Tag: v2.6.33-rc3~40^2~7^2~2
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=49829ea74f790d3be2e803a617e714f5b9a5ed50;p=~shefty%2Frdma-dev.git

drbd: Fix test of unsigned in _drbd_fault_random()

rsp->count is unsigned so the test does not work.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
---

diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c
index af30ca97493..ecc1612df67 100644
--- a/drivers/block/drbd/drbd_main.c
+++ b/drivers/block/drbd/drbd_main.c
@@ -3623,7 +3623,7 @@ _drbd_fault_random(struct fault_random_state *rsp)
 {
 	long refresh;
 
-	if (--rsp->count < 0) {
+	if (!rsp->count--) {
 		get_random_bytes(&refresh, sizeof(refresh));
 		rsp->state += refresh;
 		rsp->count = FAULT_RANDOM_REFRESH;