From: Julia Lawall <julia@diku.dk>
Date: Mon, 16 Aug 2010 06:28:19 +0000 (+0000)
Subject: net/ax25: Use available error codes
X-Git-Tag: v2.6.37-rc1~147^2~793
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=49339ccae5ba361b62e829886117dbce4b77194f;p=~emulex%2Finfiniband.git

net/ax25: Use available error codes

Error codes are stored in err, but the return value is always 0.  Return
err instead.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
local idexpression x;
constant C;
@@

if (...) { ...
  x = -C
  ... when != x
(
  return <+...x...+>;
|
  return NULL;
|
  return;
|
* return ...;
)
}
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c
index cfdfd7e2a17..26eaebf4aaa 100644
--- a/net/ax25/af_ax25.c
+++ b/net/ax25/af_ax25.c
@@ -1103,7 +1103,7 @@ done:
 out:
 	release_sock(sk);
 
-	return 0;
+	return err;
 }
 
 /*