From: Jarek Poplawski Date: Tue, 9 Jan 2007 22:38:31 +0000 (-0800) Subject: [IPV4] devinet: inetdev_init out label moved after RCU assignment X-Git-Tag: v2.6.20-rc5~29^2 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=483479ecc565b7f5845997138eddf5ecbc2684b1;p=~emulex%2Finfiniband.git [IPV4] devinet: inetdev_init out label moved after RCU assignment inetdev_init out label moved after RCU assignment (final suggestion by Herbert Xu) Signed-off-by: Jarek Poplawski Acked-by: Herbert Xu Signed-off-by: David S. Miller --- diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index 25c8a42965d..480ace9819f 100644 --- a/net/ipv4/devinet.c +++ b/net/ipv4/devinet.c @@ -174,9 +174,10 @@ struct in_device *inetdev_init(struct net_device *dev) ip_mc_init_dev(in_dev); if (dev->flags & IFF_UP) ip_mc_up(in_dev); -out: + /* we can receive as soon as ip_ptr is set -- do this last */ rcu_assign_pointer(dev->ip_ptr, in_dev); +out: return in_dev; out_kfree: kfree(in_dev);