From: KOSAKI Motohiro Date: Tue, 26 Oct 2010 21:21:43 +0000 (-0700) Subject: vmscan: remove dead code in shrink_inactive_list() X-Git-Tag: v2.6.37-rc1~105^2~138 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=47185052165a4c5de0a461018238375dd982c2ec;p=~emulex%2Finfiniband.git vmscan: remove dead code in shrink_inactive_list() After synchrounous lumpy reclaim, the page_list is guaranteed to not have active pages as page activation in shrink_page_list() disables lumpy reclaim. Remove the dead code. Signed-off-by: KOSAKI Motohiro Signed-off-by: Mel Gorman Reviewed-by: Minchan Kim Cc: Johannes Weiner Cc: Wu Fengguang Cc: Rik van Riel Cc: KAMEZAWA Hiroyuki Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/mm/vmscan.c b/mm/vmscan.c index d9fc2dce93a..cec8081bbd9 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1331,7 +1331,6 @@ shrink_inactive_list(unsigned long nr_to_scan, struct zone *zone, unsigned long nr_scanned; unsigned long nr_reclaimed = 0; unsigned long nr_taken; - unsigned long nr_active; unsigned long nr_anon; unsigned long nr_file; @@ -1386,13 +1385,6 @@ shrink_inactive_list(unsigned long nr_to_scan, struct zone *zone, /* Check if we should syncronously wait for writeback */ if (should_reclaim_stall(nr_taken, nr_reclaimed, priority, sc)) { - /* - * The attempt at page out may have made some - * of the pages active, mark them inactive again. - */ - nr_active = clear_active_flags(&page_list, NULL); - count_vm_events(PGDEACTIVATE, nr_active); - set_lumpy_reclaim_mode(priority, sc, true); nr_reclaimed += shrink_page_list(&page_list, sc); }