From: Dotan Barak <dotanb@dev.mellanox.co.il>
Date: Mon, 31 Oct 2011 15:53:07 +0000 (-0700)
Subject: rdma/cma: minor code refactoring when saving a string content
X-Git-Tag: v1.0.16~62
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=404c828cadf8a5370c80d0edffc4f23c97e229f2;p=~shefty%2Flibrdmacm.git

rdma/cma: minor code refactoring when saving a string content

In this case, using strdup will provide a cleaner code
(and maybe a little bit faster too).

Signed-off-by: Dotan Barak <dotanb@dev.mellanox.co.il>
Signed-off-by: Sean Hefty <sean.hefty@intel.com>
---

diff --git a/src/addrinfo.c b/src/addrinfo.c
index 695430b0..34c7fb4f 100755
--- a/src/addrinfo.c
+++ b/src/addrinfo.c
@@ -137,9 +137,7 @@ static int ucma_convert_to_rai(struct rdma_addrinfo *rai,
 	if (!addr)
 		return ERR(ENOMEM);
 
-	canonname = ai->ai_canonname ? malloc(strlen(ai->ai_canonname) + 1) : NULL;
-	if (canonname)
-		strcpy(canonname, ai->ai_canonname);
+	canonname = ai->ai_canonname ? strdup(ai->ai_canonname) : NULL;
 
 	memcpy(addr, ai->ai_addr, ai->ai_addrlen);
 	if (ai->ai_flags & RAI_PASSIVE) {