From: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
Date: Tue, 16 Dec 2014 17:45:25 +0000 (+0200)
Subject: of/overlay: Do not generate duplicate nodes
X-Git-Tag: v3.19-rc6~15^2~2
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=3e7f7626fd49a9ffba8520a1a073f62929acad63;p=~emulex%2Finfiniband.git

of/overlay: Do not generate duplicate nodes

During the course of the rewrites a bug sneaked in when dealing
with children nodes of overlays, which ends up duplicating
sub nodes.

Simply remove the duplicate traversal of child nodes to fix.

Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
Signed-off-by: Grant Likely <grant.likely@linaro.org>
---

diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
index ea63fbd228e..352b4f28f82 100644
--- a/drivers/of/overlay.c
+++ b/drivers/of/overlay.c
@@ -114,17 +114,6 @@ static int of_overlay_apply_single_device_node(struct of_overlay *ov,
 		ret = of_overlay_apply_one(ov, tchild, child);
 		if (ret)
 			return ret;
-
-		/* The properties are already copied, now do the child nodes */
-		for_each_child_of_node(child, grandchild) {
-			ret = of_overlay_apply_single_device_node(ov, tchild, grandchild);
-			if (ret) {
-				pr_err("%s: Failed to apply single node @%s/%s\n",
-					__func__, tchild->full_name,
-					grandchild->name);
-				return ret;
-			}
-		}
 	}
 
 	return ret;