From: Bruce Allan Date: Wed, 5 Dec 2012 06:26:46 +0000 (+0000) Subject: e1000e: cleanup magic number X-Git-Tag: v3.9-rc1~139^2~365^2~2 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=3a3104e7d022ec24862448d167a21de46accf6e8;p=~emulex%2Finfiniband.git e1000e: cleanup magic number Signed-off-by: Bruce Allan Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- diff --git a/drivers/net/ethernet/intel/e1000e/nvm.c b/drivers/net/ethernet/intel/e1000e/nvm.c index 71938ed2d3c..1e7882c7d6d 100644 --- a/drivers/net/ethernet/intel/e1000e/nvm.c +++ b/drivers/net/ethernet/intel/e1000e/nvm.c @@ -464,8 +464,8 @@ s32 e1000_read_pba_string_generic(struct e1000_hw *hw, u8 *pba_num, if (nvm_data != NVM_PBA_PTR_GUARD) { e_dbg("NVM PBA number is not stored as string\n"); - /* we will need 11 characters to store the PBA */ - if (pba_num_size < 11) { + /* make sure callers buffer is big enough to store the PBA */ + if (pba_num_size < E1000_PBANUM_LENGTH) { e_dbg("PBA string buffer too small\n"); return E1000_ERR_NO_SPACE; }