From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 16 Dec 2011 20:25:29 +0000 (+0300)
Subject: NFC: double unlock in nfc_llcp_recv_connect()
X-Git-Tag: v3.3-rc1~182^2~44^2~63
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=341ee4349f31e42fb0eb20d340d15309ac760308;p=~emulex%2Finfiniband.git

NFC: double unlock in nfc_llcp_recv_connect()

We unlock inside the if block on the other side of this if else
statement.  It could result in calling mutex_unlock() twice.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---

diff --git a/net/nfc/llcp/llcp.c b/net/nfc/llcp/llcp.c
index 67756b23eac..f99d6b4658e 100644
--- a/net/nfc/llcp/llcp.c
+++ b/net/nfc/llcp/llcp.c
@@ -554,11 +554,9 @@ static void nfc_llcp_recv_connect(struct nfc_llcp_local *local,
 				goto enqueue;
 			}
 		}
-
+		mutex_unlock(&local->socket_lock);
 	}
 
-	mutex_unlock(&local->socket_lock);
-
 	reason = LLCP_DM_NOBOUND;
 	goto fail;