From: J. Bruce Fields <bfields@redhat.com>
Date: Tue, 17 Aug 2010 22:46:33 +0000 (-0400)
Subject: nfsd4: bad BUG() in preprocess_stateid_op
X-Git-Tag: v2.6.36-rc3~14^2~4
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=30c0e1ef0a8a6cab4e0f9357698c81a2f7f73cc5;p=~shefty%2Frdma-dev.git

nfsd4: bad BUG() in preprocess_stateid_op

It's OK for this function to return without setting filp--we do it in
the special-stateid case.

And there's a legitimate case where we can hit this, since we do permit
reads on write-only stateid's.

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---

diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 0a024917f05..b990eadb799 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -2983,7 +2983,6 @@ nfs4_preprocess_stateid_op(struct nfsd4_compound_state *cstate,
 				*filpp = find_readable_file(stp->st_file);
 			else
 				*filpp = find_writeable_file(stp->st_file);
-			BUG_ON(!*filpp); /* assured by check_openmode */
 		}
 	}
 	status = nfs_ok;