From: Ingo Molnar <mingo@elte.hu>
Date: Thu, 27 Mar 2008 20:29:09 +0000 (+0100)
Subject: x86: prefetch fix #2
X-Git-Tag: v2.6.25-rc8~72
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=3085354de635179d70c240e6d942bcbd1d93056c;p=~emulex%2Finfiniband.git

x86: prefetch fix #2

Linus noticed a second bug and an uncleanliness:

 - we'd return on any instruction fetch fault

 - we'd use both the value of 16 and the PF_INSTR symbol which are
   the same and make no sense

the cleanup nicely unifies this piece of logic.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---

diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c
index c0c82bc143c..ec08d838985 100644
--- a/arch/x86/mm/fault.c
+++ b/arch/x86/mm/fault.c
@@ -91,13 +91,10 @@ static int is_prefetch(struct pt_regs *regs, unsigned long addr,
 	int prefetch = 0;
 	unsigned char *max_instr;
 
-#ifdef CONFIG_X86_32
-	/* Catch an obscure case of prefetch inside an NX page: */
-	if ((__supported_pte_mask & _PAGE_NX) && (error_code & 16))
-		return 0;
-#endif
-
-	/* If it was a exec fault on NX page, ignore */
+	/*
+	 * If it was a exec (instruction fetch) fault on NX page, then
+	 * do not ignore the fault:
+	 */
 	if (error_code & PF_INSTR)
 		return 0;