From: Arnaud Lacombe <lacombar@gmail.com>
Date: Thu, 14 Oct 2010 00:43:28 +0000 (-0400)
Subject: kconfig/conf: reduce the scope of `defconfig_file'
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=275744cc8da0fd006e8f8fc1090f01dc0296810d;p=~shefty%2Frdma-dev.git

kconfig/conf: reduce the scope of `defconfig_file'

This variable is not used outside of main() so there is not much reason keeping
it global. Ensure it is initialized as gcc has no way to know that normal
execution path expect only one option switch to be given on the command line
(except when we request help). As a result, we always initialize
`defconfig_file' before using it.

Signed-off-by: Arnaud Lacombe <lacombar@gmail.com>
---

diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
index 08c05bcc82c..6431f5c004d 100644
--- a/scripts/kconfig/conf.c
+++ b/scripts/kconfig/conf.c
@@ -34,8 +34,6 @@ enum input_mode {
 	oldnoconfig,
 } input_mode = oldaskconfig;
 
-char *defconfig_file;
-
 static int indent = 1;
 static int valid_stdin = 1;
 static int sync_kconfig;
@@ -462,7 +460,7 @@ static struct option long_opts[] = {
 int main(int ac, char **av)
 {
 	int opt;
-	const char *name;
+	const char *name, *defconfig_file = NULL /* gcc uninit */;
 	struct stat tmpstat;
 
 	setlocale(LC_ALL, "");