From: Zhao Yakui Date: Tue, 26 Aug 2008 05:57:34 +0000 (+0800) Subject: ACPI: Avoid bogus timeout about SMbus check X-Git-Tag: v2.6.27-rc6~39^2~1^2 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=266feefeb9ea2d846ac82eb6db1a54b230364ba4;p=~shefty%2Frdma-dev.git ACPI: Avoid bogus timeout about SMbus check In the function of wait_transaction_complete when the timeout happens, OS will try to check the status of SMbus again. If the status is what OS expected, it will be regarded as the bogus timeout. Otherwise it will be treated as ETIME. http://bugzilla.kernel.org/show_bug.cgi?id=10483 Signed-off-by: Zhao Yakui tested-by : Oldřich Jedlička < Signed-off-by: Andi Kleen --- diff --git a/drivers/acpi/sbshc.c b/drivers/acpi/sbshc.c index bcf2c70fca8..a4e3767b8c6 100644 --- a/drivers/acpi/sbshc.c +++ b/drivers/acpi/sbshc.c @@ -107,6 +107,13 @@ static int wait_transaction_complete(struct acpi_smb_hc *hc, int timeout) if (wait_event_timeout(hc->wait, smb_check_done(hc), msecs_to_jiffies(timeout))) return 0; + /* + * After the timeout happens, OS will try to check the status of SMbus. + * If the status is what OS expected, it will be regarded as the bogus + * timeout. + */ + if (smb_check_done(hc)) + return 0; else return -ETIME; }