From: Daniel Walker <dwalker@fifo99.com>
Date: Mon, 5 Oct 2009 20:31:45 +0000 (-0700)
Subject: omap: iovmm: Add missing mutex_unlock
X-Git-Tag: v2.6.32-rc4~33^2~4
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=265489003c463f3d78d622fba60d56d16b3009dd;p=~shefty%2Frdma-dev.git

omap: iovmm: Add missing mutex_unlock

I was using Coccinelle with the mutex_unlock semantic patch, and it
unconvered this problem. It appears to be a valid missing unlock issue.
This change should correct it by moving the unlock below the label.

This patch is against the mainline kernel.

Cc: Julia Lawall <julia@diku.dk>
Cc: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
Signed-off-by: Daniel Walker <dwalker@fifo99.com>
Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---

diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c
index 0e5573d5bb5..dc3fac3dd0e 100644
--- a/arch/arm/plat-omap/iovmm.c
+++ b/arch/arm/plat-omap/iovmm.c
@@ -363,8 +363,9 @@ void *da_to_va(struct iommu *obj, u32 da)
 		goto out;
 	}
 	va = area->va;
-	mutex_unlock(&obj->mmap_lock);
 out:
+	mutex_unlock(&obj->mmap_lock);
+
 	return va;
 }
 EXPORT_SYMBOL_GPL(da_to_va);