From: Eric W. Biederman Date: Sat, 13 Feb 2010 03:22:24 +0000 (-0800) Subject: sysfs: Pack sysfs_dirent more tightly. X-Git-Tag: v2.6.34-rc1~1^2~12 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=19c38b632d4554329986021fd66bdea468cf452c;p=~shefty%2Frdma-dev.git sysfs: Pack sysfs_dirent more tightly. Placing the 16bit s_mode between a pointer and a long doesn't pack well especailly on 64bit where we wast 48 bits. So move s_mode and declare it as a unsigned short. This is the sysfs backing store after all we don't need fields extra large just in case someday we want userspace to be able to use a larger value. Acked-by: Tejun Heo Signed-off-by: Eric W. Biederman Signed-off-by: Greg Kroah-Hartman --- diff --git a/fs/sysfs/sysfs.h b/fs/sysfs/sysfs.h index 37e0e086233..5a3192a0844 100644 --- a/fs/sysfs/sysfs.h +++ b/fs/sysfs/sysfs.h @@ -66,8 +66,8 @@ struct sysfs_dirent { }; unsigned int s_flags; + unsigned short s_mode; ino_t s_ino; - umode_t s_mode; struct sysfs_inode_attrs *s_iattr; };