From: Joseph Qi Date: Wed, 11 Sep 2013 21:19:55 +0000 (-0700) Subject: ocfs2: add the missing return value check of ocfs2_xattr_get_clusters X-Git-Tag: v3.12-rc1~52^2~287 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=17caf9555edc27a0c6df512de0879b357ebacae4;p=~emulex%2Finfiniband.git ocfs2: add the missing return value check of ocfs2_xattr_get_clusters In ocfs2_xattr_value_attach_refcount(), if error occurs when calling ocfs2_xattr_get_clusters(), it will go with unexpected behavior since local variables p_cluster, num_clusters and ext_flags are declared without initialization. Signed-off-by: Joseph Qi Cc: Joel Becker Cc: Mark Fasheh Acked-by: Jie Liu Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c index 317ef0abccb..1cbc2231a9f 100644 --- a/fs/ocfs2/xattr.c +++ b/fs/ocfs2/xattr.c @@ -5881,6 +5881,10 @@ static int ocfs2_xattr_value_attach_refcount(struct inode *inode, while (cpos < clusters) { ret = ocfs2_xattr_get_clusters(inode, cpos, &p_cluster, &num_clusters, el, &ext_flags); + if (ret) { + mlog_errno(ret); + break; + } cpos += num_clusters; if ((ext_flags & OCFS2_EXT_REFCOUNTED))