From: David S. Miller <davem@davemloft.net>
Date: Thu, 9 Oct 2008 23:40:29 +0000 (-0700)
Subject: ppp: Use skb_queue_walk() in ppp_mp_insert().
X-Git-Tag: v2.6.28-rc1~717^2~10
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=13c9821ea49be153ea74e5987cf6955871d7b124;p=~shefty%2Frdma-dev.git

ppp: Use skb_queue_walk() in ppp_mp_insert().

Instead of open-coded version.

Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/ppp_generic.c b/drivers/net/ppp_generic.c
index 5d4d21516a6..0ca0fcbb7c0 100644
--- a/drivers/net/ppp_generic.c
+++ b/drivers/net/ppp_generic.c
@@ -1863,9 +1863,10 @@ ppp_mp_insert(struct ppp *ppp, struct sk_buff *skb)
 
 	/* N.B. we don't need to lock the list lock because we have the
 	   ppp unit receive-side lock. */
-	for (p = list->next; p != (struct sk_buff *)list; p = p->next)
+	skb_queue_walk(list, p) {
 		if (seq_before(seq, p->sequence))
 			break;
+	}
 	__skb_queue_before(list, p, skb);
 }