From: Sean Hefty <sean.hefty@intel.com>
Date: Thu, 19 Aug 2010 22:00:29 +0000 (-0700)
Subject: librdmacm: do not pass uninitialized ai_hints into getaddrinfo
X-Git-Tag: v1.0.14~11
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=125a4b39d3f788a544568a0971819749daa4e455;p=~shefty%2Flibrdmacm.git

librdmacm: do not pass uninitialized ai_hints into getaddrinfo

If rdma_getaddrinfo is called with hints set to NULL, then an
uninitialized ai_hints structure will be passed into getaddrinfo.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
---

diff --git a/src/addrinfo.c b/src/addrinfo.c
old mode 100644
new mode 100755
index c8d9f0c0..7c7056fa
--- a/src/addrinfo.c
+++ b/src/addrinfo.c
@@ -136,17 +136,21 @@ int rdma_getaddrinfo(char *node, char *service,
 {
 	struct rdma_addrinfo *rai;
 	struct addrinfo ai_hints;
-	struct addrinfo *ai;
+	struct addrinfo *ai, *aih;
 	int ret;
 
 	ret = ucma_init();
 	if (ret)
 		return ret;
 
-	if (hints)
+	if (hints) {
 		ucma_convert_to_ai(&ai_hints, hints);
+		aih = &ai_hints;
+	} else {
+		aih = NULL;
+	}
 
-	ret = getaddrinfo(node, service, &ai_hints, &ai);
+	ret = getaddrinfo(node, service, aih, &ai);
 	if (ret)
 		return ret;