From: Josef Bacik Date: Fri, 24 Aug 2012 18:48:11 +0000 (-0400) Subject: Btrfs: only warn if we hit an error when doing the tree logging X-Git-Tag: v3.7-rc1~71^2~91 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=0fa83cdb1d72a94ea84ab6380747de6ac7cc8753;p=~emulex%2Finfiniband.git Btrfs: only warn if we hit an error when doing the tree logging I hit this a couple times while working on my fsync patch (all my bugs, not normal operation), but with my new stuff we could have new errors from cases I have not encountered, so instead of BUG()'ing we should be WARN()'ing so that we are notified there is a problem but the user doesn't lose their data. We can easily commit the transaction in the case that the tree logging fails and still be fine, so let's try and be as nice to the user as possible. Thanks, Signed-off-by: Josef Bacik --- diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c index f2ff02c5513..94db438494d 100644 --- a/fs/btrfs/tree-log.c +++ b/fs/btrfs/tree-log.c @@ -3346,7 +3346,7 @@ int btrfs_log_inode_parent(struct btrfs_trans_handle *trans, end_trans: dput(old_parent); if (ret < 0) { - BUG_ON(ret != -ENOSPC); + WARN_ON(ret != -ENOSPC); root->fs_info->last_trans_log_full_commit = trans->transid; ret = 1; }