From: Ben Hutchings <bhutchings@solarflare.com>
Date: Thu, 13 Jan 2011 19:47:56 +0000 (+0000)
Subject: PCI: sysfs: Fix failure path for addition of "vpd" attribute
X-Git-Tag: v2.6.39-rc1~416^2~15
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=0f12a4e29368a9476076515881d9ef4e5876c6e2;p=~shefty%2Frdma-dev.git

PCI: sysfs: Fix failure path for addition of "vpd" attribute

Commit 280c73d ("PCI: centralize the capabilities code in
pci-sysfs.c") changed the initialisation of the "rom" and "vpd"
attributes, and made the failure path for the "vpd" attribute
incorrect.  We must free the new attribute structure (attr), but
instead we currently free dev->vpd->attr.  That will normally be NULL,
resulting in a memory leak, but it might be a stale pointer, resulting
in a double-free.

Found by inspection; compile-tested only.

Cc: stable@kernel.org
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
---

diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
index 8ecaac98392..cf2b3654b4a 100644
--- a/drivers/pci/pci-sysfs.c
+++ b/drivers/pci/pci-sysfs.c
@@ -1087,7 +1087,7 @@ static int pci_create_capabilities_sysfs(struct pci_dev *dev)
 		attr->write = write_vpd_attr;
 		retval = sysfs_create_bin_file(&dev->dev.kobj, attr);
 		if (retval) {
-			kfree(dev->vpd->attr);
+			kfree(attr);
 			return retval;
 		}
 		dev->vpd->attr = attr;