From: Martin Schwidefsky Date: Thu, 3 Mar 2011 16:56:05 +0000 (+0100) Subject: [S390] xpram: remove __initdata attribute from module parameters X-Git-Tag: v2.6.38-rc8~6^2~2 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=0c0db0355bc070b4c623622248d3f577642536b9;p=~shefty%2Frdma-dev.git [S390] xpram: remove __initdata attribute from module parameters The module parameter 'devs' and 'sizes' are marked as __initdata. The memory for the parameters are freed after module_init completed. This can lead to kernel crashes in param_free_charp. Remove the __initdata attribute to fix the problem. Signed-off-by: Martin Schwidefsky --- diff --git a/drivers/s390/block/xpram.c b/drivers/s390/block/xpram.c index c881a14fa5d..1f6a4d894e7 100644 --- a/drivers/s390/block/xpram.c +++ b/drivers/s390/block/xpram.c @@ -62,8 +62,8 @@ static int xpram_devs; /* * Parameter parsing functions. */ -static int __initdata devs = XPRAM_DEVS; -static char __initdata *sizes[XPRAM_MAX_DEVS]; +static int devs = XPRAM_DEVS; +static char *sizes[XPRAM_MAX_DEVS]; module_param(devs, int, 0); module_param_array(sizes, charp, NULL, 0);