From: Devin Heitmueller <dheitmueller@kernellabs.com>
Date: Tue, 7 Aug 2012 01:46:57 +0000 (-0300)
Subject: [media] xc5000: properly report i2c write failures
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=0a3dabb15ef9039188464647113398ed95400318;p=~shefty%2Frdma-dev.git

[media] xc5000: properly report i2c write failures

The logic as written would *never* actually return an error condition,
since the loop would run until the counter hit zero but the check was
for a value less than zero.

Signed-off-by: Devin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
---

diff --git a/drivers/media/common/tuners/xc5000.c b/drivers/media/common/tuners/xc5000.c
index a3f775a2ccd..7189e06fb35 100644
--- a/drivers/media/common/tuners/xc5000.c
+++ b/drivers/media/common/tuners/xc5000.c
@@ -343,7 +343,7 @@ static int xc_write_reg(struct xc5000_priv *priv, u16 regAddr, u16 i2cData)
 			}
 		}
 	}
-	if (WatchDogTimer < 0)
+	if (WatchDogTimer <= 0)
 		result = XC_RESULT_I2C_WRITE_FAILURE;
 
 	return result;