From: H Hartley Sweeten Date: Thu, 19 Dec 2013 23:32:08 +0000 (-0700) Subject: staging: comedi: ni_660x: tidy up set_tio_counterswap() X-Git-Tag: v3.14-rc1~150^2~169 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=01b6442b4639a0165880aefeec5342df37e02aa8;p=~emulex%2Finfiniband.git staging: comedi: ni_660x: tidy up set_tio_counterswap() Clean up the multi-line comment and tidy the function a bit. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/ni_660x.c b/drivers/staging/comedi/drivers/ni_660x.c index 40402c14ba9..df42e390617 100644 --- a/drivers/staging/comedi/drivers/ni_660x.c +++ b/drivers/staging/comedi/drivers/ni_660x.c @@ -767,17 +767,20 @@ static int ni_660x_cancel(struct comedi_device *dev, struct comedi_subdevice *s) return retval; } -static void set_tio_counterswap(struct comedi_device *dev, int chipset) +static void set_tio_counterswap(struct comedi_device *dev, int chip) { - /* See P. 3.5 of the Register-Level Programming manual. The - CounterSwap bit has to be set on the second chip, otherwise - it will try to use the same pins as the first chip. + unsigned bits = 0; + + /* + * See P. 3.5 of the Register-Level Programming manual. + * The CounterSwap bit has to be set on the second chip, + * otherwise it will try to use the same pins as the + * first chip. */ - if (chipset) - ni_660x_write_register(dev, chipset, CounterSwap, - NI660X_CLK_CFG); - else - ni_660x_write_register(dev, chipset, 0, NI660X_CLK_CFG); + if (chip) + bits = CounterSwap; + + ni_660x_write_register(dev, chip, bits, NI660X_CLK_CFG); } static void ni_660x_handle_gpct_interrupt(struct comedi_device *dev,