]> git.openfabrics.org - ~emulex/infiniband.git/commitdiff
watchdog: Don't overwrite error value in wm831x_wdt_set_timeout()
authorMark Brown <broonie@opensource.wolfsonmicro.com>
Wed, 16 Nov 2011 11:52:12 +0000 (11:52 +0000)
committerWim Van Sebroeck <wim@iguana.be>
Wed, 16 Nov 2011 21:00:10 +0000 (22:00 +0100)
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
drivers/watchdog/wm831x_wdt.c

index 7be38556aed0c5b0854a89704875218f15437b02..e789a47db41f4dc1c618efaba3c8e189851c42bb 100644 (file)
@@ -150,7 +150,7 @@ static int wm831x_wdt_set_timeout(struct watchdog_device *wdt_dev,
                if (wm831x_wdt_cfgs[i].time == timeout)
                        break;
        if (i == ARRAY_SIZE(wm831x_wdt_cfgs))
-               ret = -EINVAL;
+               return -EINVAL;
 
        ret = wm831x_reg_unlock(wm831x);
        if (ret == 0) {