]> git.openfabrics.org - ~emulex/infiniband.git/commitdiff
dma: remove unnecessary null pointer check in mmp_pdma.c
authorCong Ding <dinggnu@gmail.com>
Tue, 15 Jan 2013 00:19:48 +0000 (01:19 +0100)
committerVinod Koul <vinod.koul@intel.com>
Sun, 20 Jan 2013 13:49:40 +0000 (05:49 -0800)
the pointer cfg is dereferenced in line 594, so it's no reason to check null
again in line 620.

Signed-off-by: Cong Ding <dinggnu@gmail.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/mmp_pdma.c

index 13bdf4a7e1ec67a0bfe9bfb0e1938707c2d8c339..41ad6a62f8383a72ca35f7a2380b7f4aca529677 100644 (file)
@@ -617,10 +617,8 @@ static int mmp_pdma_control(struct dma_chan *dchan, enum dma_ctrl_cmd cmd,
                else if (maxburst == 32)
                        chan->dcmd |= DCMD_BURST32;
 
-               if (cfg) {
-                       chan->dir = cfg->direction;
-                       chan->drcmr = cfg->slave_id;
-               }
+               chan->dir = cfg->direction;
+               chan->drcmr = cfg->slave_id;
                chan->dev_addr = addr;
                break;
        default: