]> git.openfabrics.org - ~shefty/rdma-dev.git/commitdiff
nilfs2: remove unneeded test in nilfs_writepage()
authorVyacheslav Dubeyko <slava@dubeyko.com>
Tue, 30 Apr 2013 22:27:51 +0000 (15:27 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 1 May 2013 00:04:05 +0000 (17:04 -0700)
page->mapping->host cannot be NULL in nilfs_writepage(), so remove the
unneeded test.

The fixes the smatch warning: "fs/nilfs2/inode.c:211 nilfs_writepage()
error: we previously assumed 'inode' could be null (see line 195)".

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Vyacheslav Dubeyko <slava@dubeyko.com>
Cc: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/nilfs2/inode.c

index ba7a1da7634b2a19a7a01da2dba9712fd6e2971b..cf02f5530713e4354b20119d68346bcd25f8ec57 100644 (file)
@@ -192,7 +192,7 @@ static int nilfs_writepage(struct page *page, struct writeback_control *wbc)
        struct inode *inode = page->mapping->host;
        int err;
 
-       if (inode && (inode->i_sb->s_flags & MS_RDONLY)) {
+       if (inode->i_sb->s_flags & MS_RDONLY) {
                /*
                 * It means that filesystem was remounted in read-only
                 * mode because of error or metadata corruption. But we