]> git.openfabrics.org - ~shefty/rdma-dev.git/commitdiff
V4L/DVB (7836): cinergyT2 build fix
authorIngo Molnar <mingo@elte.hu>
Sun, 4 May 2008 23:32:45 +0000 (20:32 -0300)
committerMauro Carvalho Chehab <mchehab@infradead.org>
Wed, 14 May 2008 05:54:03 +0000 (02:54 -0300)
x86.git testing found the following build bug in v2.6.26-rc1:

  drivers/built-in.o: In function `cinergyt2_probe':
  cinergyT2.c:(.text+0xb6117): undefined reference to `input_allocate_device'
  cinergyT2.c:(.text+0xb6230): undefined reference to `input_register_device'
  cinergyT2.c:(.text+0xb623d): undefined reference to `input_free_device'

with the following config:

  http://redhat.com/~mingo/misc/config-Sun_May__4_22_06_54_CEST_2008.bad

The reason for the bug is that the cinergyT2 driver depends on
CONFIG_INPUT functionality, but if INPUT is modular it's still possible
to build CONFIG_DVB_CINERGYT2=y - which leads to missing symbols.

The solution is to make DVB_CINERGYT2 dependent on INPUT.

[ This solves the build problem - i have not tested the driver on this card. ]

Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
drivers/media/dvb/cinergyT2/Kconfig

index 3d778c5aba68ea8035d70c4265bd1a364039e53d..c03513b2ccaee79b34bc85fbff88e81028011bc7 100644 (file)
@@ -1,6 +1,6 @@
 config DVB_CINERGYT2
        tristate "Terratec CinergyT2/qanu USB2 DVB-T receiver"
-       depends on DVB_CORE && USB
+       depends on DVB_CORE && USB && INPUT
        help
          Support for "TerraTec CinergyT2" USB2.0 Highspeed DVB Receivers