windows: comp_channel.cpp is included by util.c in the openib_common.

Remove it from device.c in individual providers to avoid
duplicate definitions.

Line endings were corrected to linux format from windows as part of
the change.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>

diff --git a/dapl/openib_cma/device.c b/dapl/openib_cma/device.c
index 99b8c5536b962cce0bf522fc71e054e0d713be2b..e4ff22eb79633e55052e67c2fcbe6218abf6f6e0 100644 (file)
--- a/dapl/openib_cma/device.c
+++ b/dapl/openib_cma/device.c
@@ -54,7 +54,6 @@ DAPL_OS_LOCK g_hca_lock;
 struct dapl_llist_entry *g_hca_list;
 
 #if defined(_WIN64) || defined(_WIN32)
-#include "..\..\..\..\..\etc\user\comp_channel.cpp"
 #include <rdma\winverbs.h>
 
 static COMP_SET ufds;
@@ -144,43 +143,43 @@ static int dapls_thread_signal(void)
 }
 #endif
 
-/* Get IP address using network name, address, or device name */\r
-static int getipaddr(char *name, char *addr, int len)\r
-{\r
-        struct addrinfo *res;\r
-\r
-        /* assume netdev for first attempt, then network and address type */\r
-        if (getipaddr_netdev(name, addr, len)) {\r
-                if (getaddrinfo(name, NULL, NULL, &res)) {\r
-                        dapl_log(DAPL_DBG_TYPE_ERR,\r
-                                 " open_hca: getaddr_netdev ERROR:"\r
-                                 " %s. Is %s configured?\n",\r
-                                 strerror(errno), name);\r
-                        return 1;\r
-                } else {\r
-                        if (len >= res->ai_addrlen)\r
-                                memcpy(addr, res->ai_addr, res->ai_addrlen);\r
-                        else {\r
-                                freeaddrinfo(res);\r
-                                return 1;\r
-                        }\r
-                        freeaddrinfo(res);\r
-                }\r
-        }\r
-\r
-        dapl_dbg_log(\r
-                DAPL_DBG_TYPE_UTIL,\r
-                " getipaddr: family %d port %d addr %d.%d.%d.%d\n",\r
-                ((struct sockaddr_in *)addr)->sin_family,\r
-                ((struct sockaddr_in *)addr)->sin_port,\r
-                ((struct sockaddr_in *)addr)->sin_addr.s_addr >> 0 & 0xff,\r
-                ((struct sockaddr_in *)addr)->sin_addr.s_addr >> 8 & 0xff,\r
-                ((struct sockaddr_in *)addr)->sin_addr.s_addr >> 16 & 0xff,\r
-                ((struct sockaddr_in *)addr)->sin_addr.\r
-                 s_addr >> 24 & 0xff);\r
-\r
-        return 0;\r
-}\r
+/* Get IP address using network name, address, or device name */
+static int getipaddr(char *name, char *addr, int len)
+{
+        struct addrinfo *res;
+
+        /* assume netdev for first attempt, then network and address type */
+        if (getipaddr_netdev(name, addr, len)) {
+                if (getaddrinfo(name, NULL, NULL, &res)) {
+                        dapl_log(DAPL_DBG_TYPE_ERR,
+                                 " open_hca: getaddr_netdev ERROR:"
+                                 " %s. Is %s configured?\n",
+                                 strerror(errno), name);
+                        return 1;
+                } else {
+                        if (len >= res->ai_addrlen)
+                                memcpy(addr, res->ai_addr, res->ai_addrlen);
+                        else {
+                                freeaddrinfo(res);
+                                return 1;
+                        }
+                        freeaddrinfo(res);
+                }
+        }
+
+        dapl_dbg_log(
+                DAPL_DBG_TYPE_UTIL,
+                " getipaddr: family %d port %d addr %d.%d.%d.%d\n",
+                ((struct sockaddr_in *)addr)->sin_family,
+                ((struct sockaddr_in *)addr)->sin_port,
+                ((struct sockaddr_in *)addr)->sin_addr.s_addr >> 0 & 0xff,
+                ((struct sockaddr_in *)addr)->sin_addr.s_addr >> 8 & 0xff,
+                ((struct sockaddr_in *)addr)->sin_addr.s_addr >> 16 & 0xff,
+                ((struct sockaddr_in *)addr)->sin_addr.
+                 s_addr >> 24 & 0xff);
+
+        return 0;
+}
 
 /*
  * dapls_ib_init, dapls_ib_release

diff --git a/dapl/openib_scm/device.c b/dapl/openib_scm/device.c
index a5b0742f46b06476a5cf764274dd5557d57f3a3d..4c50f0340d2987a08f0145331ea65ee15427f11d 100644 (file)
--- a/dapl/openib_scm/device.c
+++ b/dapl/openib_scm/device.c
@@ -67,7 +67,6 @@ DAT_RETURN  dapli_ib_thread_init(void);
 void dapli_ib_thread_destroy(void);
 
 #if defined(_WIN64) || defined(_WIN32)
-#include "..\..\..\..\..\etc\user\comp_channel.cpp"
 #include <rdma\winverbs.h>
 
 static COMP_SET ufds;

diff --git a/dapl/openib_ucm/device.c b/dapl/openib_ucm/device.c
index 1f324b352deeaeea560a5d5b9a94b6a3fe29cf0d..1959c767896f43a65e0afb9af06a0eda4a8c73fc 100644 (file)
--- a/dapl/openib_ucm/device.c
+++ b/dapl/openib_ucm/device.c
@@ -37,17 +37,16 @@ static void ucm_service_destroy(IN DAPL_HCA *hca);
 static int  ucm_service_create(IN DAPL_HCA *hca);
 
 #if defined (_WIN32)
-#include "..\..\..\..\..\etc\user\comp_channel.cpp"
 #include <rdma\winverbs.h>
 
 static int32_t create_os_signal(IN DAPL_HCA * hca_ptr)
 {
-       return CompSetInit(&hca_ptr->ib_trans.signal.set);\r
+       return CompSetInit(&hca_ptr->ib_trans.signal.set);
 }
 
 static void destroy_os_signal(IN DAPL_HCA * hca_ptr)
 {
-       CompSetCleanup(&hca_ptr->ib_trans.signal.set);\r
+       CompSetCleanup(&hca_ptr->ib_trans.signal.set);
 }
 
 static int dapls_config_verbs(struct ibv_context *verbs)