]> git.openfabrics.org - ~shefty/rdma-dev.git/commitdiff
usb: gadget: pch_udc: Fix disconnect issue
authorTomoya MORINAGA <tomoya.rohm@gmail.com>
Thu, 12 Jan 2012 02:27:05 +0000 (11:27 +0900)
committerFelipe Balbi <balbi@ti.com>
Tue, 24 Jan 2012 09:34:02 +0000 (11:34 +0200)
ISSUE:
When the driver notifies a gadget of a disconnect event, a system
rarely freezes.

CAUSE:
When the driver calls dev->driver->disconnect(), it is not calling
spin_unlock().

Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/gadget/pch_udc.c

index a3fcaae4bc2ade69ec74838f3596ecb8e00faa38..6a44c921d13ce9f032db06c0b86b3078a346cc1f 100644 (file)
@@ -2335,8 +2335,11 @@ static void pch_udc_svc_ur_interrupt(struct pch_udc_dev *dev)
                /* Complete request queue */
                empty_req_queue(ep);
        }
-       if (dev->driver && dev->driver->disconnect)
+       if (dev->driver && dev->driver->disconnect) {
+               spin_unlock(&dev->lock);
                dev->driver->disconnect(&dev->gadget);
+               spin_lock(&dev->lock);
+       }
 }
 
 /**