V4L/DVB (10283): cx18: Call request_module() with proper argument types.

request_module() needs to be called with a string literal for a
format string or with 1 or more variable arguments to avoid
compiler warnings and possible exploits, if someone could cause
us to get a format string with a '%' code in the format string
when we make the call.

Reported-by: Brandon Jenkins <bcjenkins@tvwhere.com>
Signed-off-by: Andy Walls <awalls@radix.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

diff --git a/drivers/media/video/cx18/cx18-driver.c b/drivers/media/video/cx18/cx18-driver.c
index 450c48dd995ae20922887ff3b92e5c391ee9e925..1d3a865b9c6da533dfeca9a67861426269aaf648 100644 (file)
--- a/drivers/media/video/cx18/cx18-driver.c
+++ b/drivers/media/video/cx18/cx18-driver.c
@@ -728,7 +728,7 @@ static u32 cx18_request_module(struct cx18 *cx, u32 hw,
 {
        if ((hw & id) == 0)
                return hw;
-       if (request_module(name) != 0) {
+       if (request_module("%s", name) != 0) {
                CX18_ERR("Failed to load module %s\n", name);
                return hw & ~id;
        }