]> git.openfabrics.org - ~emulex/infiniband.git/commitdiff
i2c: omap: simplify num_bytes handling
authorFelipe Balbi <balbi@ti.com>
Wed, 12 Sep 2012 10:57:56 +0000 (16:27 +0530)
committerWolfram Sang <w.sang@pengutronix.de>
Wed, 12 Sep 2012 13:01:52 +0000 (15:01 +0200)
trivial patch, no functional changes

If the fifo is disabled or fifo_size is 0 the num_bytes
is set to 1. Else it is set to fifo_size or in case of a
draining interrupt the remaining bytes in the buff stat.
So the zero check is redundant and can be safely optimised.

Signed-off-by: Felipe Balbi <balbi@ti.com>
Reviewed-by : Santosh Shilimkar <santosh.shilimkar@ti.com>
Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
drivers/i2c/busses/i2c-omap.c

index 2d9b03c9461404128850cad97f02162299085aa3..236cb38bb859222938ae4607c1b6a6886097c0ef 100644 (file)
@@ -812,8 +812,7 @@ complete:
                                                        OMAP_I2C_BUFSTAT_REG)
                                                        >> 8) & 0x3F;
                        }
-                       while (num_bytes) {
-                               num_bytes--;
+                       while (num_bytes--) {
                                w = omap_i2c_read_reg(dev, OMAP_I2C_DATA_REG);
                                if (dev->buf_len) {
                                        *dev->buf++ = w;
@@ -855,8 +854,7 @@ complete:
                                                        OMAP_I2C_BUFSTAT_REG)
                                                        & 0x3F;
                        }
-                       while (num_bytes) {
-                               num_bytes--;
+                       while (num_bytes--) {
                                w = 0;
                                if (dev->buf_len) {
                                        w = *dev->buf++;