ath6kl: Remove unnecessary retrieval of first list entry in ath6kl_htc_tx_setup_scat_...

It is unnecessary to take the first list entry from queue again for
transmission. Sometimes it may look racy when the head of the list
changes between subsequent retrival, but should not happen in
practical.

Reported-by: Jouni Malinen <jouni@qca.qualcomm.com>
Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>

diff --git a/drivers/net/wireless/ath/ath6kl/htc.c b/drivers/net/wireless/ath/ath6kl/htc.c
index 9aa2e4447900b743205b8d5122ed8aab2cdac41e..feed98535c9f976c0a8e3566b64addcfe427828b 100644 (file)
--- a/drivers/net/wireless/ath/ath6kl/htc.c
+++ b/drivers/net/wireless/ath/ath6kl/htc.c
@@ -389,7 +389,6 @@ static int ath6kl_htc_tx_setup_scat_list(struct htc_target *target,
 
                rem_scat -= len;
                /* now remove it from the queue */
-               packet = list_first_entry(queue, struct htc_packet, list);
                list_del(&packet->list);
 
                scat_req->scat_list[i].packet = packet;