]> git.openfabrics.org - ~emulex/infiniband.git/commitdiff
imx-drm: imx-ldb: Use snprintf()
authorFabio Estevam <fabio.estevam@freescale.com>
Fri, 28 Feb 2014 14:39:42 +0000 (11:39 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Feb 2014 22:56:34 +0000 (14:56 -0800)
Use snprintf() in order to fix the following static checker warning:

drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string overflow. buf_size: 16 length: 18
probably 18 is theory and not real life, but 16 is based on
theory as well.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/imx-drm/imx-ldb.c

index abf85170f6d6afbc370a59fc086c9a95eccfe77b..daa54df4527f274cdee17262827ad1a1b4c5b41b 100644 (file)
@@ -334,12 +334,12 @@ static int imx_ldb_get_clk(struct imx_ldb *ldb, int chno)
 {
        char clkname[16];
 
-       sprintf(clkname, "di%d", chno);
+       snprintf(clkname, sizeof(clkname), "di%d", chno);
        ldb->clk[chno] = devm_clk_get(ldb->dev, clkname);
        if (IS_ERR(ldb->clk[chno]))
                return PTR_ERR(ldb->clk[chno]);
 
-       sprintf(clkname, "di%d_pll", chno);
+       snprintf(clkname, sizeof(clkname), "di%d_pll", chno);
        ldb->clk_pll[chno] = devm_clk_get(ldb->dev, clkname);
 
        return PTR_ERR_OR_ZERO(ldb->clk_pll[chno]);