]> git.openfabrics.org - ~emulex/infiniband.git/commitdiff
staging/xgifb: Remove unnecessary binary calculation in GetXG27FPBits
authorPeter Huewe <peterhuewe@gmx.de>
Mon, 13 May 2013 21:41:48 +0000 (23:41 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 16 May 2013 23:02:34 +0000 (16:02 -0700)
If temp <= 2 no other bits than the lowest two (0x03) can be set anyway
-> this operation can be removed.

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/xgifb/vb_init.c

index ba8796fb66d6fbfb29e7ab11cf6c8ab8f4292e57..090c424d467029f3d82b40dca754a881311f1e0b 100644 (file)
@@ -1177,9 +1177,7 @@ static unsigned char GetXG27FPBits(struct vb_device_info *pVBInfo)
        /* enable GPIOA/B/C read */
        xgifb_reg_and_or(pVBInfo->P3d4, 0x4A, ~0x03, 0x03);
        temp = xgifb_reg_get(pVBInfo->P3d4, 0x48);
-       if (temp <= 2)
-               temp &= 0x03;
-       else
+       if (temp > 2)
                temp = ((temp & 0x04) >> 1) | ((~temp) & 0x01);
 
        xgifb_reg_set(pVBInfo->P3d4, 0x4A, CR4A);