]> git.openfabrics.org - ~shefty/rdma-dev.git/commitdiff
[media] drxk_hard: fix the return code from an error handler
authorMauro Carvalho Chehab <mchehab@redhat.com>
Mon, 29 Oct 2012 09:58:59 +0000 (07:58 -0200)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Mon, 29 Oct 2012 10:04:09 +0000 (08:04 -0200)
While it is very unlikely, if the number of parameters for
QAMDemodulatorCommand is not 2 or 4, status become undefined:

/home/hans/work/build/v4l-dvb-git/drivers/media/dvb-frontends/drxk_hard.c: In function ‘QAMDemodulatorCommand’:
/home/hans/work/build/v4l-dvb-git/drivers/media/dvb-frontends/drxk_hard.c:5452:5: warning: ‘status’ may be used uninitialized in this function [-Wuninitialized]

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/dvb-frontends/drxk_hard.c

index 59382fbb3286b0e2ab676342cea82489fb9107e5..76a4e5cf8730af35b299b7db39707a9ea9fb71cd 100644 (file)
@@ -5446,6 +5446,7 @@ static int QAMDemodulatorCommand(struct drxk_state *state,
        } else {
                printk(KERN_WARNING "drxk: Unknown QAM demodulator parameter "
                        "count %d\n", numberOfParameters);
+               status = -EINVAL;
        }
 
 error: