ARM: mx5/babbage: Use gpio_request_one in babbage_usbhub_reset

Current code inside babbage_usbhub_reset uses gpio_direction_output with initial value of the GPIO and also sets
the GPIO value via gpio_set_value to the same level right after. This is not needed.

By using gpio_request_one it is possible to set the direction and initial value in one shot.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
LAKML-Reference: 1300377359-23212-2-git-send-email-fabio.estevam@freescale.com
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

diff --git a/arch/arm/mach-mx5/board-mx51_babbage.c b/arch/arm/mach-mx5/board-mx51_babbage.c
index bea4e4135f9def09d56bd794040a14ec0d409f11..ab50aa9d268caa9521455d72f5bbab0150acd3be 100644 (file)
--- a/arch/arm/mach-mx5/board-mx51_babbage.c
+++ b/arch/arm/mach-mx5/board-mx51_babbage.c
@@ -208,18 +208,16 @@ static inline void babbage_usbhub_reset(void)
 {
        int ret;
 
-       /* Bring USB hub out of reset */
-       ret = gpio_request(BABBAGE_USB_HUB_RESET, "GPIO1_7");
+       /* Reset USB hub */
+       ret = gpio_request_one(BABBAGE_USB_HUB_RESET,
+                                       GPIOF_OUT_INIT_LOW, "GPIO1_7");
        if (ret) {
                printk(KERN_ERR"failed to get GPIO_USB_HUB_RESET: %d\n", ret);
                return;
        }
-       gpio_direction_output(BABBAGE_USB_HUB_RESET, 0);
 
-       /* USB HUB RESET - De-assert USB HUB RESET_N */
-       msleep(1);
-       gpio_set_value(BABBAGE_USB_HUB_RESET, 0);
-       msleep(1);
+       msleep(2);
+       /* Deassert reset */
        gpio_set_value(BABBAGE_USB_HUB_RESET, 1);
 }