]> git.openfabrics.org - ~shefty/ibacm.git/commitdiff
ibacm: Eliminate compiling warning "ignoring return value"
authorKaike Wan <kaike.wan@intel.com>
Tue, 15 Apr 2014 23:27:10 +0000 (16:27 -0700)
committerSean Hefty <sean.hefty@intel.com>
Wed, 16 Apr 2014 06:33:33 +0000 (23:33 -0700)
Those warnings are produced when building rpm with
"rpmbuild -ta ibacm-1.0.8.tar.gz" after creating the
tar file with "make dist".

Signed-off-by: Kaike Wan <kaike.wan@intel.com>
Signed-off-by: Sean Hefty <sean.hefty@intel.com>
src/acm.c
src/libacm.c

index 11f89c776e6c56306653ce9c811be96da250f073..267a588ec96a61b2daac37f2b94de0d82ec63325 100644 (file)
--- a/src/acm.c
+++ b/src/acm.c
@@ -4164,7 +4164,11 @@ static int acm_open_lock_file(void)
        }
 
        snprintf(pid, sizeof pid, "%d\n", getpid());
-       write(lock_fd, pid, strlen(pid));
+       if (write(lock_fd, pid, strlen(pid)) != strlen(pid)){
+               lockf(lock_fd, F_ULOCK, 0);
+               close(lock_fd);
+               return -1;
+       }
        return 0;
 }
 
@@ -4183,9 +4187,12 @@ static void daemonize(void)
        if (chdir("/"))
                exit(1);
 
-       freopen("/dev/null", "r", stdin);
-       freopen("/dev/null", "w", stdout);
-       freopen("/dev/null", "w", stderr);
+       if(!freopen("/dev/null", "r", stdin))
+               exit(1);
+       if(!freopen("/dev/null", "w", stdout))
+               exit(1);
+       if(!freopen("/dev/null", "w", stderr))
+               exit(1);
 }
 
 static void show_usage(char *program)
index 4e42233616b9037588a125d33f7d23cb7bd3a1af..6ed653c9c263872bb638dde750a7bab4cbf9ea84 100644 (file)
@@ -49,7 +49,8 @@ static void acm_set_server_port(void)
        FILE *f;
 
        if ((f = fopen("/var/run/ibacm.port", "r"))) {
-               fscanf(f, "%hu", (unsigned short *) &server_port);
+               if (fscanf(f, "%hu", (unsigned short *) &server_port) != 1) 
+                       printf("Failed to read server port\n"); 
                fclose(f);
        }
 }