qlogic: get rid of a redundant test for NULL before call to release_firmware()

Since release_firmware() deals gracefully with being passed a NULL
pointer there is no reason to test explicitly before calling the
function.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c
index 718b274403511c600fb43aae956c9adf46a274e9..1fb149c9b3016ec93b0cc0730f640e9c8613e39b 100644 (file)
--- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c
+++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c
@@ -1261,8 +1261,7 @@ next:
 void
 netxen_release_firmware(struct netxen_adapter *adapter)
 {
-       if (adapter->fw)
-               release_firmware(adapter->fw);
+       release_firmware(adapter->fw);
        adapter->fw = NULL;
 }
 

diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c
index d32cf0ddf1b9f37dd098690f59b5888cd569e5ec..799fd40ed03ad3643cc7d28ed927c10e3bc80c7e 100644 (file)
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c
@@ -1321,8 +1321,7 @@ next:
 void
 qlcnic_release_firmware(struct qlcnic_adapter *adapter)
 {
-       if (adapter->fw)
-               release_firmware(adapter->fw);
+       release_firmware(adapter->fw);
        adapter->fw = NULL;
 }