]> git.openfabrics.org - ~shefty/rdma-dev.git/commitdiff
leds/leds-s3c24xx: use devm_gpio_request
authorDevendra Naga <devendra.aaru@gmail.com>
Wed, 11 Jul 2012 09:50:32 +0000 (17:50 +0800)
committerBryan Wu <bryan.wu@canonical.com>
Mon, 23 Jul 2012 23:52:40 +0000 (07:52 +0800)
why?
because if the led_classdev_register fails we wont do gpio free
because using devm_ functions, there is no need for error paths

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
drivers/leds/leds-s3c24xx.c

index e1206407616d8660bb91471354b8a7b326e5944c..942f0ea1817832f3d82389b8369bf6b2c545a457 100644 (file)
@@ -65,7 +65,6 @@ static int s3c24xx_led_remove(struct platform_device *dev)
        struct s3c24xx_gpio_led *led = pdev_to_gpio(dev);
 
        led_classdev_unregister(&led->cdev);
-       gpio_free(led->pdata->gpio);
 
        return 0;
 }
@@ -92,7 +91,7 @@ static int s3c24xx_led_probe(struct platform_device *dev)
 
        led->pdata = pdata;
 
-       ret = gpio_request(pdata->gpio, "S3C24XX_LED");
+       ret = devm_gpio_request(&dev->dev, pdata->gpio, "S3C24XX_LED");
        if (ret < 0)
                return ret;