Input: palmas-pwrbutton - use IRQF_ONESHOT

make C=2 CHECK="scripts/coccicheck" MODE=report COCCI=scripts/coccinelle/misc/irqf_oneshot.cocci ./drivers/input/misc/palmas-pwrbutton.o
Reports:
drivers/input/misc/palmas-pwrbutton.c:213:9-29: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

Palmas power button just needs threaded IRQ handler since I2C operations
are involved and there is nothing in non-threaded primary handler we could
do.

So mark the request with ONESHOT as it should have been done in these
cases.

Fixes: adff5962fdd2 ("Input: introduce palmas-pwrbutton")
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

diff --git a/drivers/input/misc/palmas-pwrbutton.c b/drivers/input/misc/palmas-pwrbutton.c
index 3f902110c293c94926e5a4a069ab36e5878f7db9..766f594b45e22d1dbec2127756706e10c2f68a68 100644 (file)
--- a/drivers/input/misc/palmas-pwrbutton.c
+++ b/drivers/input/misc/palmas-pwrbutton.c
@@ -211,7 +211,9 @@ static int palmas_pwron_probe(struct platform_device *pdev)
 
        pwron->irq = platform_get_irq(pdev, 0);
        error = request_threaded_irq(pwron->irq, NULL, pwron_irq,
-                                    IRQF_TRIGGER_HIGH | IRQF_TRIGGER_LOW,
+                                    IRQF_TRIGGER_HIGH |
+                                       IRQF_TRIGGER_LOW |
+                                       IRQF_ONESHOT,
                                     dev_name(dev), pwron);
        if (error) {
                dev_err(dev, "Can't get IRQ for pwron: %d\n", error);