]> git.openfabrics.org - ~emulex/infiniband.git/commitdiff
KVM: PPC: Book3E: Unlock mmu_lock when setting caching atttribute
authorMihai Caraman <mihai.caraman@freescale.com>
Wed, 18 Jun 2014 15:45:05 +0000 (18:45 +0300)
committerAlexander Graf <agraf@suse.de>
Tue, 24 Jun 2014 13:37:25 +0000 (15:37 +0200)
The patch 08c9a188d0d0fc0f0c5e17d89a06bb59c493110f
   kvm: powerpc: use caching attributes as per linux pte
do not handle properly the error case, letting mmu_lock locked. The lock
will further generate a RCU stall from kvmppc_e500_emul_tlbwe() caller.

In case of an error go to out label.

Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>
Signed-off-by: Alexander Graf <agraf@suse.de>
arch/powerpc/kvm/e500_mmu_host.c

index dd2cc03f406f9a0e1f844473ca92c5560eca6c67..86903d3f5a033d215b3857f979fcea2cb68a3de6 100644 (file)
@@ -473,7 +473,8 @@ static inline int kvmppc_e500_shadow_map(struct kvmppc_vcpu_e500 *vcpu_e500,
                if (printk_ratelimit())
                        pr_err("%s: pte not present: gfn %lx, pfn %lx\n",
                                __func__, (long)gfn, pfn);
-               return -EINVAL;
+               ret = -EINVAL;
+               goto out;
        }
        kvmppc_e500_ref_setup(ref, gtlbe, pfn, wimg);