]> git.openfabrics.org - ~shefty/librdmacm.git/commitdiff
rdma/cma: minor code refactoring when saving a string content
authorDotan Barak <dotanb@dev.mellanox.co.il>
Mon, 31 Oct 2011 15:53:07 +0000 (08:53 -0700)
committerSean Hefty <sean.hefty@intel.com>
Mon, 31 Oct 2011 15:54:50 +0000 (08:54 -0700)
In this case, using strdup will provide a cleaner code
(and maybe a little bit faster too).

Signed-off-by: Dotan Barak <dotanb@dev.mellanox.co.il>
Signed-off-by: Sean Hefty <sean.hefty@intel.com>
src/addrinfo.c

index 695430b0d5621cee724957fc1ae5a92980c30344..34c7fb4f421ea23e779e6db921bf421ccdc8cbaf 100755 (executable)
@@ -137,9 +137,7 @@ static int ucma_convert_to_rai(struct rdma_addrinfo *rai,
        if (!addr)
                return ERR(ENOMEM);
 
-       canonname = ai->ai_canonname ? malloc(strlen(ai->ai_canonname) + 1) : NULL;
-       if (canonname)
-               strcpy(canonname, ai->ai_canonname);
+       canonname = ai->ai_canonname ? strdup(ai->ai_canonname) : NULL;
 
        memcpy(addr, ai->ai_addr, ai->ai_addrlen);
        if (ai->ai_flags & RAI_PASSIVE) {