]> git.openfabrics.org - ~emulex/infiniband.git/commitdiff
sched: Fix exec_start/task_hot on migrated tasks
authorBen Segall <bsegall@google.com>
Thu, 15 May 2014 22:59:20 +0000 (15:59 -0700)
committerIngo Molnar <mingo@kernel.org>
Thu, 22 May 2014 09:16:25 +0000 (11:16 +0200)
task_hot checks exec_start on any runnable task, but if it has been
migrated since the it last ran, then exec_start is a clock_task from
another cpu. If the old cpu's clock_task was sufficiently far ahead of
this cpu's then the task will not be considered for another migration
until it has run. Instead reset exec_start whenever a task is migrated,
since it is presumably no longer hot anyway.

Signed-off-by: Ben Segall <bsegall@google.com>
[ Made it compile. ]
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/20140515225920.7179.13924.stgit@sword-of-the-dawn.mtv.corp.google.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/fair.c

index 28ccf502c63ca4ed7712f7c8ba98caba02fbcfa0..dd3fa14a29988c090265514946371cd87444ce79 100644 (file)
@@ -4544,6 +4544,9 @@ migrate_task_rq_fair(struct task_struct *p, int next_cpu)
                atomic_long_add(se->avg.load_avg_contrib,
                                                &cfs_rq->removed_load);
        }
+
+       /* We have migrated, no longer consider this task hot */
+       se->exec_start = 0;
 }
 #endif /* CONFIG_SMP */