]> git.openfabrics.org - ~shefty/rdma-dev.git/commitdiff
xen: events: fix error checks in bind_*_to_irqhandler()
authorNicolas Kaiser <nikai@nikai.net>
Wed, 30 Mar 2011 19:14:26 +0000 (21:14 +0200)
committerKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Wed, 30 Mar 2011 19:37:04 +0000 (15:37 -0400)
Checking 'irq < 0' doesn't work when 'irq' is unsigned.

The assigned bind_evtchn_to_irq() and bind_virq_to_irq()
return int, so using int appears appropriate.

Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
drivers/xen/events.c

index 036343ba204eaab47758641c8657cb37bba08f54..589f0a53a604d822d88cc3145cb2b558a633db37 100644 (file)
@@ -912,8 +912,7 @@ int bind_evtchn_to_irqhandler(unsigned int evtchn,
                              unsigned long irqflags,
                              const char *devname, void *dev_id)
 {
-       unsigned int irq;
-       int retval;
+       int irq, retval;
 
        irq = bind_evtchn_to_irq(evtchn);
        if (irq < 0)
@@ -955,8 +954,7 @@ int bind_virq_to_irqhandler(unsigned int virq, unsigned int cpu,
                            irq_handler_t handler,
                            unsigned long irqflags, const char *devname, void *dev_id)
 {
-       unsigned int irq;
-       int retval;
+       int irq, retval;
 
        irq = bind_virq_to_irq(virq, cpu);
        if (irq < 0)