]> git.openfabrics.org - ~shefty/rdma-dev.git/commitdiff
V4L/DVB (9662): uvcvideo: Fix printk badness when printing ioctl names
authorLaurent Pinchart <laurent.pinchart@skynet.be>
Mon, 17 Nov 2008 21:32:11 +0000 (18:32 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Mon, 29 Dec 2008 19:53:36 +0000 (17:53 -0200)
Add a trailing newline character after calling v4l_printk_ioctl() to avoid
messing the kernel log up and merge the uvc_v4l2_ioctl message with the ioctl
name.

Signed-off-by: Laurent Pinchart <laurent.pinchart@skynet.be>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/uvc/uvc_v4l2.c

index 01b48a87a9b962759167eee6ba04ef019c3a8269..7b1c1363583c8e55762062e1547f0d2b05500aea 100644 (file)
@@ -464,9 +464,6 @@ static int uvc_v4l2_do_ioctl(struct file *file, unsigned int cmd, void *arg)
        struct uvc_fh *handle = (struct uvc_fh *)file->private_data;
        int ret = 0;
 
-       if (uvc_trace_param & UVC_TRACE_IOCTL)
-               v4l_printk_ioctl(cmd);
-
        switch (cmd) {
        /* Query capabilities */
        case VIDIOC_QUERYCAP:
@@ -983,7 +980,12 @@ static int uvc_v4l2_do_ioctl(struct file *file, unsigned int cmd, void *arg)
 static int uvc_v4l2_ioctl(struct inode *inode, struct file *file,
                     unsigned int cmd, unsigned long arg)
 {
-       uvc_trace(UVC_TRACE_CALLS, "uvc_v4l2_ioctl\n");
+       if (uvc_trace_param & UVC_TRACE_IOCTL) {
+               uvc_printk(KERN_DEBUG, "uvc_v4l2_ioctl(");
+               v4l_printk_ioctl(cmd);
+               printk(")\n");
+       }
+
        return video_usercopy(file, cmd, arg, uvc_v4l2_do_ioctl);
 }